Skip to content

Disable LM-specific checks when in --library-manager=false mode #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Disable LM-specific checks when in --library-manager=false mode #164

merged 1 commit into from
Mar 9, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Mar 9, 2021

The documentation of the --library-manager flag promises that, when set to false, Library Manager-specific rules will
not run. Despite this, some such rules were configured to be warnings when in --library-manager=false mode.

The documentation of the `--library-manager` flag promises that, when set to `false`, Library Manager-specific rules will
not run. Despite this, some such rules were configured to be warnings when in --library-manager=false mode.
@per1234 per1234 added priority: high Resolution is a high priority topic: code Related to content of the project itself type: bug labels Mar 9, 2021
@per1234 per1234 requested a review from silvanocerza March 9, 2021 08:52
@per1234 per1234 merged commit f665529 into arduino:main Mar 9, 2021
@per1234 per1234 deleted the fix-lm-specific-rules-configuration branch March 9, 2021 15:54
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@rsora rsora added criticality: high Of high impact and removed priority: high Resolution is a high priority labels Nov 2, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: high Of high impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants